Move ingest/kafka/* metrics into a separate section on the metrics docs #6895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QiuMM
reviewed
Jan 25, 2019
docs/content/operations/metrics.md
Outdated
| ## Ingestion Metrics | ||
| ## Ingestion Metrics (Kafka Indexing Service) | ||
|
|
||
| These metrics are applicable for the Kafka Indexing service. |
There was a problem hiding this comment.
nit: Kafka Indexing service -> Kafka Indexing Service.
The `ingest/kafka/*` metrics were grouped together with metrics relevant to RealtimeMetricsMonitor, whereas they should be in their own section.
janeklb
force-pushed
the
jlb/metrics-docs
branch
from
ca4c37b
to
480fc02
Compare
QiuMM
approved these changes
Jan 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ingest/kafka/*metrics were grouped together with metrics relevantto RealtimeMetricsMonitor, whereas they should be in their own section.
(note: i'm assuming that
RealtimeMetricsMonitoris not required for theingest/kafka/*metrics to work here - that could very well be wrong)